-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action to build PR #345
Conversation
Signed-off-by: Yevhen Vydolob <[email protected]>
Do we still need Travis running for PRs if we are going to use github actions? |
At the end, we do not need Travis, but now it is used for release vscode-yaml to npm registry. I'm not sure why, maybe @gorkem can answer? I keep travis only for that release. |
Can we turn it off for PRs? But keep it for release? |
Looks like there is a test failing on wins. |
Yes, I'm looking on it |
Yes I think, but I still don't know why we release vscode extension on npm registry. So maybe we can remove travis at all? |
Signed-off-by: Yevhen Vydolob <[email protected]>
I couldn't find out why it was done originally but people have asked for it to be updated before: #283 |
OK, then, will keep travis for release, and remove it from building PR. I have plan to move release to GH Actions as separate workflow, in separate PR. |
Maybe we need travis on the PR so we know that the release will pass? |
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
This Action only build PR, for three main OS.