Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action to build PR #345

Merged
merged 5 commits into from
Aug 20, 2020
Merged

Add GitHub Action to build PR #345

merged 5 commits into from
Aug 20, 2020

Conversation

evidolob
Copy link
Collaborator

This Action only build PR, for three main OS.

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob self-assigned this Aug 18, 2020
@joshuawilson
Copy link
Member

Do we still need Travis running for PRs if we are going to use github actions?

@evidolob
Copy link
Collaborator Author

At the end, we do not need Travis, but now it is used for release vscode-yaml to npm registry. I'm not sure why, maybe @gorkem can answer? I keep travis only for that release.

@joshuawilson
Copy link
Member

Can we turn it off for PRs? But keep it for release?

@gorkem
Copy link
Collaborator

gorkem commented Aug 18, 2020

Looks like there is a test failing on wins.

@evidolob
Copy link
Collaborator Author

Looks like there is a test failing on wins.

Yes, I'm looking on it

@evidolob
Copy link
Collaborator Author

Can we turn it off for PRs? But keep it for release?

Yes I think, but I still don't know why we release vscode extension on npm registry. So maybe we can remove travis at all?
@gorkem WDYT?

Signed-off-by: Yevhen Vydolob <[email protected]>
@JPinkney
Copy link
Contributor

I couldn't find out why it was done originally but people have asked for it to be updated before: #283

@evidolob
Copy link
Collaborator Author

OK, then, will keep travis for release, and remove it from building PR.

I have plan to move release to GH Actions as separate workflow, in separate PR.

@joshuawilson
Copy link
Member

Maybe we need travis on the PR so we know that the release will pass?
As for npm, I think it might be to provide types since you can't get that from the API.

Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob merged commit 35d8383 into master Aug 20, 2020
@evidolob evidolob deleted the add-gh-actions branch August 20, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants