Use 'next' version of yaml-ls #378
Conversation
Signed-off-by: Yevhen Vydolob <[email protected]>
|
I thought using |
|
No, in master branch we will use |
|
OK, that makes sense. Any idea if there is a check we can add to the release process to ensure we are NOT pointing at |
|
I think, we can add check in to release job, let me think about that |
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
|
@joshuawilson I add check on release CI job, that we do not have |
Signed-off-by: Yevhen Vydolob <[email protected]>
| for (const dep in dependencies) { | ||
| if (Object.prototype.hasOwnProperty.call(dependencies, dep)) { | ||
| const version = dependencies[dep]; | ||
| if (version === 'next') { |
There was a problem hiding this comment.
This appears to be a general filter across all dependencies. I do not think we would want next as a version on anything but if we do, then this would prevent the release.
Do we want it broad or specific?
There was a problem hiding this comment.
I do not think that release with next version is good idea, for any dependency. Because it is a tag, not a some specific version, and real version behind that tag may change, and you may ged unpredictable behaviour in future.
There was a problem hiding this comment.
I agree. I just want us to be intentional in what we do.
…ce-folders-temp-fix Check if dynamic registration is enabled before executing onDidChangeWorkspaceFolders
What does this PR do?
This PR changes version of
yaml-language-servertonextwhich allow use the latest changes in yaml-language-server