Add in non-standard lsp request for resolving schemas on the client-side #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Pinkney <[email protected]>
evidolob
approved these changes
Nov 26, 2020
yaml/registerVSCodeContentRequest Signed-off-by: Josh Pinkney <[email protected]>
bleach31
pushed a commit
to bleach31/vscode-yaml
that referenced
this pull request
Jan 25, 2022
* add code action to open json schema Signed-off-by: Yevhen Vydolob <[email protected]> * Fix eslint warning, fix review comments Signed-off-by: Yevhen Vydolob <[email protected]> * Fix tests Signed-off-by: Yevhen Vydolob <[email protected]> * simplify code actions implementation Signed-off-by: Yevhen Vydolob <[email protected]> * add code action to open schema only if 'showDocument' supported Signed-off-by: Yevhen Vydolob <[email protected]> * Fix tests Signed-off-by: Yevhen Vydolob <[email protected]> * fix test Signed-off-by: Yevhen Vydolob <[email protected]> * Add supported protocol version in readme Signed-off-by: Yevhen Vydolob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney [email protected]
What does this PR do?
This PR is the client-side request to redhat-developer/yaml-language-server#359. The client-side handles the schema downloading and sending the information back to the yaml language server
What issues does this PR fix or reference?
#107
Is it tested? How?
The only way I know how to test this is on the Red Hat VPN.
You'll need the server side changes: redhat-developer/yaml-language-server#359
Once you connect to the VPN these schemas should resolve correctly