-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom text document content provider #418
Conversation
Signed-off-by: Yevhen Vydolob <[email protected]>
I like this approach because it means that we won't need to manually download schemas ourselves to show remote schemas. I feel like handling remote schemas, downloading them, making sure they are updated, etc would be a pain. I guess in the end the only difference is that users on different ides/editors can't jump to remote schemas but I'm not sure how big of a deal that is |
@JPinkney I was thinking for adding some sort cache for remote JSON Schemas, we already have issues to support offline work - #386 |
That sounds like a good approach! |
Signed-off-by: Yevhen Vydolob <[email protected]>
@JPinkney Can you look on this PR again? I also find that we use |
would using eTag make the cache more efficient? |
@gorkem It can, I'm was thinking on rewriting caching on this PR. |
Signed-off-by: Yevhen Vydolob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Josh Pinkney <[email protected]>
… open-schema Signed-off-by: Yevhen Vydolob <[email protected]>
…priority-levels Re-add schema priority levels
What does this PR do?
Add implementation for text document content provider which handle
json-schema
URI shema, to open JSON Schema in VScode editorWhat issues does this PR fix or reference?
#174
Is it tested? How?