Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telemetry #490

Merged
merged 7 commits into from
May 19, 2021
Merged

Add telemetry #490

merged 7 commits into from
May 19, 2021

Conversation

evidolob
Copy link
Collaborator

What does this PR do?

Add dependency to redhat.vscode-commons and send telemetry data.
It add hadler and pass all telemetry_event from yaml-ls.

Also it send telemetry with any errors logged in LSP communication.

What issues does this PR fix or reference?

Resolve #458

@evidolob
redhat-developer#458 add telemetry
2255495 
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob self-assigned this Apr 21, 2021
@evidolob
fix test
610909d 
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob requested a review from fbricon April 30, 2021 11:36
JPinkney
JPinkney reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's some inconsistent spacing between some methods, some do:

method1
method2

like here: https://github.com/redhat-developer/vscode-yaml/pull/490/files?file-filters%5B%5D=.ts#diff-87dc6d96fc959744de13764f38871c3357de6cb849052ca9a0806a8b4d7552f8R24

and other times its

method1

method2

like https://github.com/redhat-developer/vscode-yaml/pull/490/files?file-filters%5B%5D=.ts#diff-87dc6d96fc959744de13764f38871c3357de6cb849052ca9a0806a8b4d7552f8R60

fbricon
fbricon requested changes Apr 30, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/telemetry.ts Outdated Show resolved Hide resolved
src/telemetry.ts Outdated Show resolved Hide resolved
@evidolob evidolob requested a review from fbricon May 11, 2021 12:57
@evidolob
fix build
449961d 
Signed-off-by: Yevhen Vydolob <[email protected]>
fbricon
fbricon approved these changes May 11, 2021
View reviewed changes
test/telemetry.test.ts Outdated Show resolved Hide resolved
joshuawilson
joshuawilson reviewed May 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
joshuawilson
joshuawilson reviewed May 11, 2021
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
@evidolob
Rename test and constant
f41a4a0 
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob
fix typo
89f08ae 
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob merged commit fec9024 into redhat-developer:master May 19, 2021
@evidolob evidolob deleted the add-telemetry branch May 19, 2021 08:13
@ssbarnea ssbarnea mentioned this pull request May 18, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon approved these changes

@joshuawilson joshuawilson joshuawilson approved these changes

@JPinkney JPinkney JPinkney approved these changes

Assignees

@evidolob evidolob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add telemetry reporting
4 participants
@evidolob @fbricon @joshuawilson @JPinkney