Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vscode-redhat-telemetry to 0.4.2 #598

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Update vscode-redhat-telemetry to 0.4.2 #598

merged 1 commit into from
Sep 22, 2021

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Sep 21, 2021 •
edited
Loading

Signed-off-by: Fred Bricon [email protected]

What does this PR do?

Update vscode-redhat-telemetry to 0.4.2

What issues does this PR fix or reference?

  • reduces the amount of identify events sent to segment.com
  • better identify unique users on gitpod

Is it tested? How?

  • when running in extension development host, the host debug console will display "vscode-redhat-telemetry: Skipping 'identify' event! Already sent:" logs, after reloading. A hash of the identify event will be stored under %Code location%/User/globalStorage/vscode-redhat-telemetry/cache

gorkem
gorkem approved these changes Sep 22, 2021
View reviewed changes
Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evidolob evidolob merged commit e123e82 into redhat-developer:main Sep 22, 2021
@fbricon fbricon added this to the 0.23.0 milestone Sep 24, 2021
@fbricon fbricon deleted the update-telemetry042 branch January 24, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem gorkem gorkem approved these changes

@evidolob evidolob evidolob approved these changes

@JPinkney JPinkney Awaiting requested review from JPinkney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fbricon @gorkem @evidolob