Send startup event on LS start #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
fbricon
reviewed
Apr 12, 2022
src/extension.ts
Outdated
| @@ -176,8 +177,7 @@ export function startClient( | |||
| client.onRequest(FSReadFile.type, (fsPath: string) => { | |||
| return workspace.fs.readFile(Uri.file(fsPath)).then((uint8array) => new TextDecoder().decode(uint8array)); | |||
| }); | |||
|
|
|||
| runtime.telemetry.send({ name: 'yaml.server.initialized' }); | |||
| runtime.telemetry.sendStartupEvent(); | |||
There was a problem hiding this comment.
can we send a boolean, for (un)successful startup?, and an error message in case of unsuccessful startup
There was a problem hiding this comment.
the sendStartupEvent doesn't have any parameters, we already send all LS errors, including startup errors.
Or you mean, do not use sendStartupEvent and instead send some { name: 'yaml.server.initialized', successful : true/false } ?
There was a problem hiding this comment.
You can manually craft a startup event like:
{
name: 'startup',
properties: {
'yaml.server.initialized' : true/false,
'error': the error message if the server failed to initialize
}
}
In that case, you wouldn't call sendStartupEvent()
gorkem
approved these changes
Apr 12, 2022
msivasubramaniaan
approved these changes
Apr 13, 2022
Signed-off-by: Yevhen Vydolob <[email protected]>
fbricon
reviewed
Apr 25, 2022
fbricon
reviewed
Apr 25, 2022
fbricon
reviewed
Apr 25, 2022
fbricon
reviewed
Apr 25, 2022
Signed-off-by: Yevhen Vydolob <[email protected]>
fbricon
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
yaml.server.initializedand sendstartupinsteadWhat issues does this PR fix or reference?
Resolve #725
Is it tested? How?