Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the contributing instructions #749

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Improvements to the contributing instructions #749

merged 2 commits into from
Apr 21, 2022

Conversation

brifly
Copy link
Contributor

@brifly brifly commented Apr 20, 2022 •
edited
Loading

What does this PR do?

Some improvements to contributing guidelines to make it easier to start debugging out of the box - closes #745.

What issues does this PR fix or reference?

  • Update the language server to the ts file to avoid having to compile the language server project for each change
  • Removed the unnecessary compile step (its done anyway in the pre-launch when debugging the extension)
  • Added a line to update the outFiles of the server launch config to the correct path
  • Added a note to fix an issue I ran into when debugging where I had a port clash with another plugin

@evidolob evidolob requested a review from gorkem April 20, 2022 08:22
@msivasubramaniaan msivasubramaniaan merged commit 63ecd99 into redhat-developer:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msivasubramaniaan msivasubramaniaan msivasubramaniaan approved these changes

@gorkem gorkem gorkem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sourcemaps for the yaml server project
3 participants
@brifly @gorkem @msivasubramaniaan