Hover doesn't work when there is now symbol after property (#382)

* fix: validate the last yaml null prop * fix: add test validate on null prop Co-authored-by: Petr Spacek <[email protected]> Co-authored-by: p-spacek <[email protected]>
redhat-developer · Dec 23, 2020 · 8412e43 · 8412e43
1 parent d896e46
commit 8412e43
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/languageservice/parser/jsonParser07.ts b/src/languageservice/parser/jsonParser07.ts
@@ -405,7 +405,7 @@ export function getNodePath(node: ASTNode): JSONPath {
 
 export function contains(node: ASTNode, offset: number, includeRightBound = false): boolean {
   return (
-    (offset >= node.offset && offset < node.offset + node.length) || (includeRightBound && offset === node.offset + node.length)
+    (offset >= node.offset && offset <= node.offset + node.length) || (includeRightBound && offset === node.offset + node.length)
   );
 }
 

diff --git a/test/hover.test.ts b/test/hover.test.ts
@@ -303,5 +303,25 @@ suite('Hover Tests', () => {
         })
         .then(done, done);
     });
+
+    it('Hover on null property', (done) => {
+      languageService.addSchema(SCHEMA_ID, {
+        type: 'object',
+        properties: {
+          childObject: {
+            type: 'object',
+            description: 'should return this description',
+          },
+        },
+      });
+      const content = 'childObject: \n';
+      const hover = parseSetup(content, 1);
+      hover
+        .then(function (result) {
+          assert.equal((result.contents as MarkedString[]).length, 1);
+          assert.equal(result.contents[0], 'should return this description');
+        })
+        .then(done, done);
+    });
   });
 });