-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align with new features introduced in vscode-json-languageservice #105
Comments
I definitely think those updates would be worthy. One of my goals was to bring the yaml language server back upto date with the JSON language server because that would resolve quite a few issues but I haven't had the time. If you're willing to bring them into this repo I can definitely give them a review. I skimmed through the PR you linked on that repo and it seems like everything should work. At most it would probably just be an issue of corner cases |
@JPinkney Hi Josh, I am still working on fixing migration issues in https://github.com/pengx17/monaco-yaml right now and I think it is kinda related. Some of the changes including:
Currently I am still struggling to fixing auto-completion right now, which turns out to be quite complex task. Other than that, I think this issue is ready to move forward. And at last, I am very happy to resolve some of the issues in vscode-yaml as well :D |
Please refer to this: remcohaszing/monaco-yaml#5
If you feel like these updates are worthy, I will try to bring them into this repo as well. However I am afraid in the process of migration from JSON language service, I missed some key bug fixes for YAML syntax since there are no regression tests in our repo. I have go through some basic use cases (hover/validation) and it seems work fine though.
The text was updated successfully, but these errors were encountered: