Realign features with JSON Language Server #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPinkney
commented
May 29, 2019
src/server.ts
Outdated
| } | ||
| languageSettings = configureSchemas(uri, schema.fileMatch, schema.schema, languageSettings); | ||
| } | ||
| jsonLanguageService.configure({ |
There was a problem hiding this comment.
This is a bug, needs to be re-configured with every schema.
|
Also, $schema property should be supported in autocompletion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a massive PR but it aims to align the feature set with the JSON Language Server as much as possible.
Currently the only feature that cannot rely on the JSON Language Server is auto completion. The auto completion is currently too customised to be aligned right now.
Fixes:
#142
#140
#139
#137
#136
#133
#105
redhat-developer/vscode-yaml#153
redhat-developer/vscode-yaml#154
redhat-developer/vscode-yaml#130
redhat-developer/vscode-yaml#129
redhat-developer/vscode-yaml#106