Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local schema changes are not reflected in real-time #34

Closed
Fannon opened this issue Jan 12, 2018 · 4 comments
Closed

Local schema changes are not reflected in real-time #34

Fannon opened this issue Jan 12, 2018 · 4 comments
Assignees

Comments

@Fannon
Copy link

Fannon commented Jan 12, 2018

First thank you for creating this extension / language server!

I've noticed one problem in my particular usecase.
There I'm using JSON Schema definitions which are available locally. In case of VSCodes default JSON implementation, when the local Schema updates, the affected JSON files get re-evaluated and immediately reflect the updated Schema.

The yaml-language-server seems to cache those local schemas. I need to restart the VSCode (i guess the language-server really) to get the Schemas reloaded.

Best,
Simon

@JPinkney
Copy link
Contributor

Hmm, I've never had this issue before, its always worked for me but I'll look into it.

@JPinkney JPinkney self-assigned this Jan 12, 2018
@Fannon
Copy link
Author

Fannon commented Jan 13, 2018

Thanks!
This happened, when using workspace settings defining which schemas match.

If it would be helpful for you, I could create a small project reproducing this situation.

@JPinkney
Copy link
Contributor

@gorkem I have opened a PR for this issue on the vscode-yaml side (redhat-developer/vscode-yaml#53) but I'm not sure if this is the best way to do this. Basically what is happening is the language server only sees the version of the json schema when it is inserted into the server via the onDidChangeConfiguration. However, when a user is editing the schema the changes aren't reflected in real time. By watching all json files we by consequence also watch the json schemas in the workspace, thus fixing the issue.

@JPinkney
Copy link
Contributor

Should be fixed as of our 0.0.8 release!

JPinkney added a commit that referenced this issue Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants