Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Telemetry Notification #439

Closed
evidolob opened this issue Apr 13, 2021 · 0 comments · Fixed by #445
Closed

Implement Telemetry Notification #439

evidolob opened this issue Apr 13, 2021 · 0 comments · Fixed by #445
Assignees
@evidolob
Labels
enhancement
Milestone
0.19.0

Comments

@evidolob
Copy link
Collaborator

To log errors/warnings in to telemetry we need to implement telemetry event

Related to redhat-developer/vscode-yaml#458
@evidolob evidolob self-assigned this Apr 13, 2021
@evidolob evidolob added this to the 0.19.0 milestone Apr 13, 2021
evidolob added a commit to evidolob/yaml-language-server that referenced this issue Apr 21, 2021
@evidolob
redhat-developer#439 add telemetry notification
f6d8ea6 
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob mentioned this issue Apr 21, 2021
Merged
evidolob added a commit that referenced this issue May 19, 2021
@evidolob @JPinkney
Add telemetry notification (#445)
f808de7 
* #439 add telemetry notification

Signed-off-by: Yevhen Vydolob <[email protected]>

* Update src/languageserver/telemetry.ts

Co-authored-by: Josh Pinkney <[email protected]>

* Fix review comments

Signed-off-by: Yevhen Vydolob <[email protected]>

* reorder fields

Signed-off-by: Yevhen Vydolob <[email protected]>

* add test

Signed-off-by: Yevhen Vydolob <[email protected]>

Co-authored-by: Josh Pinkney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
enhancement
Projects
None yet
Milestone
0.19.0
Development

Successfully merging a pull request may close this issue.

Add telemetry notification evidolob/yaml-language-server
1 participant
@evidolob