Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors that come from trying to resolve schema store schemas #183

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

JPinkney
Copy link
Contributor

This PR catches the case when a user sets a proxy and the schema store schemas cannot be resolved. Previously it was throwing an error that was uncaught.

Related issues:
#182
redhat-developer/vscode-yaml#127

@JPinkney JPinkney merged commit 576241a into master Sep 13, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.589% when pulling c18ad40 on fixUnhandledPromiseRejection into 2be16f3 on master.

@evidolob evidolob deleted the fixUnhandledPromiseRejection branch August 11, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants