Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for textDocument/definition #257

Merged
merged 2 commits into from
May 1, 2020
Merged

add support for textDocument/definition #257

merged 2 commits into from
May 1, 2020

Conversation

ananthakumaran
Copy link
Contributor

This would allow the user to jump from $ref to its definition. References microsoft/vscode-json-languageservice#50 vscode-langservers/vscode-json-languageserver@cea01c4

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 77.042% when pulling 6e44d6d on ananthakumaran:findDefinition into f6b89fd on redhat-developer:master.

@JPinkney JPinkney self-requested a review May 1, 2020 13:09
JPinkney
JPinkney approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is a really cool feature! Thanks for doing this!

@JPinkney JPinkney merged commit 27522e8 into redhat-developer:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPinkney JPinkney JPinkney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananthakumaran @coveralls @JPinkney