Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation of date and time formats #292

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Add validation of date and time formats #292

merged 2 commits into from
Aug 6, 2020

Conversation

apgrucza
Copy link
Contributor

@apgrucza apgrucza commented Aug 4, 2020

These changes are copied from https://github.com/microsoft/vscode-json-languageservice/blob/master/src/parser/jsonParser.ts, upon which this file appears to be based.

JPinkney
JPinkney reviewed Aug 4, 2020
View reviewed changes
Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. Do you mind creating a few tests to cover these cases? Once that's done then I'll approve

@apgrucza
Copy link
Contributor Author

apgrucza commented Aug 5, 2020

Sure. There was no test coverage for jsonParser07.ts so I've taken all the tests from https://github.com/microsoft/vscode-json-languageservice/blob/master/src/test/parser.test.ts and put them here.

@JPinkney JPinkney merged commit 6df2d61 into redhat-developer:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPinkney JPinkney JPinkney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apgrucza @JPinkney