Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheme load on windows with full path #313

Merged
merged 3 commits into from
Sep 10, 2020

Conversation

evidolob
Copy link
Collaborator

@evidolob evidolob commented Sep 9, 2020

This PR fix scheme loading on Windows, in case if URI has window path, ie c:\some\path\to\scheme.json.

Fix: redhat-developer/vscode-yaml#347

@evidolob evidolob self-assigned this Sep 9, 2020
@coveralls
Copy link

coveralls commented Sep 9, 2020

Coverage Status

Coverage decreased (-0.03%) to 75.515% when pulling b2b2576 on evidolob:fix-vscode-yaml-347 into 56f049f on redhat-developer:master.

Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably update the readme on the yaml language server and vscode-yaml saying that this now works

@evidolob
Copy link
Collaborator Author

evidolob commented Sep 9, 2020

Hm, we never mention that this not work, I found that bug during launching tests on windows, I should add changelog record for this, but I do not think that this worth mentioning in readme.

@JPinkney
Copy link
Contributor

JPinkney commented Sep 9, 2020

In the past, people have asked whether this works, whether absolute paths vs relative paths work, etc. From my experience, some people have to have examples added in the readme thats identical to how they'd use it because they aren't going to try it out themselves until the readme says it

…rver into fix-vscode-yaml-347

Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob merged commit a8a3367 into redhat-developer:master Sep 10, 2020
@evidolob evidolob deleted the fix-vscode-yaml-347 branch September 10, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'yaml.schemas' configuration doesn't work on windows with full path
3 participants