Add isKubernetes option to doHover #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney [email protected]
What does this PR do?
This PR adds isKubernetes option to doHover. Basically what isKubernetes does is allows you to use a special comparator when evaluating oneOf/anyOf. This is needed because the generic comparator provided works well in the general case but breaks down when you have a ton of anyOf/oneOf like in the kubernetes schema:
What issues does this PR fix or reference?
Part of https://bugzilla.redhat.com/show_bug.cgi?id=1888874
Is it tested? How?
You'll need to set isKubernetes=true in yamlHover.ts before building then set:
and use:
as the yaml. Then hover over replicas, selector, etc and see that the hover is working as expected
I can write a test but the json schema for kubernetes is 70000 lines long so I could either have the test pull from the URL specified above or bring the schema into the project though checkout times would increase.