Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add schema priority levels #418

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Re-add schema priority levels #418

merged 2 commits into from
Mar 17, 2021

Conversation

JPinkney
Copy link
Contributor

@JPinkney JPinkney commented Mar 1, 2021

Signed-off-by: Josh Pinkney [email protected]

What does this PR do?

This PR re-adds in schema priority levels. Apparently, they got lost when I refactored everything

What issues does this PR fix or reference?

Is it tested? How?

@coveralls
Copy link

coveralls commented Mar 1, 2021

Coverage Status

Coverage increased (+1.03%) to 78.467% when pulling 712ec0b on schema-priority-levels into 31dbd3c on master.

@ssbarnea
Copy link
Member

ssbarnea commented Mar 8, 2021

I am really interested about this change because I currently have a serious issue caused by overlapping file matching patterns, where vscode does not respect a given order. By being able to set priorities I can help it pick the right schema.

This has the potential to address ansible/vscode-ansible#36 with minor changes on ansible extension. At this moment I cannot do anything to make it pick right schema.

@JPinkney
Copy link
Contributor Author

JPinkney commented Mar 9, 2021

This PR won't help with ansible/vscode-ansible#36. This has nothing to do with overlapping file patterns. It's related to: #362

@ssbarnea
Copy link
Member

ssbarnea commented Mar 9, 2021

This PR won't help with ansible-community/vscode-ansible#36. This has nothing to do with overlapping file patterns. It's related to: #362

My belief was that this would enable me to mention priority levels on https://github.com/ansible-community/vscode-ansible/blob/master/package.json#L103-L156 -- and as a side effect to be able to control which schema is picked.

Signed-off-by: Josh Pinkney <[email protected]>
@JPinkney JPinkney marked this pull request as ready for review March 11, 2021 19:26
Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JPinkney JPinkney merged commit 4499c21 into master Mar 17, 2021
@JPinkney JPinkney deleted the schema-priority-levels branch March 17, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants