Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotation to object key if it start with '@' #435

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

evidolob
Copy link
Collaborator

@evidolob evidolob commented Apr 8, 2021

What does this PR do?

Add quotation to object key if it start with '@'

Screen.Recording.2021-04-08.at.11.50.54.mov

What issues does this PR fix or reference?

Fix redhat-developer/vscode-yaml#439

Is it tested? How?

With test and manually, use schema provided in redhat-developer/vscode-yaml#439

@evidolob evidolob self-assigned this Apr 8, 2021
@evidolob evidolob requested a review from JPinkney as a code owner April 8, 2021 11:32
@coveralls
Copy link

coveralls commented Apr 8, 2021

Coverage Status

Coverage increased (+0.04%) to 79.486% when pulling 4e11857 on evidolob:fix-i439 into d1eca1f on redhat-developer:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keys requiring quotation can bork the schema
4 participants