Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make autocomplete automatically escape colon inside of a key #475

Merged
merged 1 commit into from
May 26, 2021

Conversation

JPinkney
Copy link
Contributor

Signed-off-by: Josh Pinkney [email protected]

What does this PR do?

This PR makes it so that colons inside of a yaml key are automatically quoted

colon-fix

What issues does this PR fix or reference?

Fixes redhat-developer/vscode-yaml#496 and #474

Is it tested? How?

Tested manually through vscode and through the test I've created

@coveralls
Copy link

coveralls commented May 26, 2021

Coverage Status

Coverage increased (+0.004%) to 79.734% when pulling abe07bf on fix-496 into 9613909 on master.

Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete not working when certain characters are in object property keys
4 participants