Use 'workspace/configuration' to fetch settings #476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It changes the way how LS receives settings/preferences, previously we fully rely on client, which use deprecated API to push settings to server. Now we use proper API to fetch settings from client.
What issues does this PR fix or reference?
Resolve #327
Is it tested? How?
with test, and manually, just run vscode-yaml and make sure that your preferences used on yaml-ls.