Fix client/registerCapability request when workspaces/didChangeWorksp… #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aceFolder even if dynamicRegistration set to false
msivasubramaniaan
requested review from
evidolob and
JPinkney
as code owners
evidolob
reviewed
Nov 26, 2021
src/yamlSettings.ts
Outdated
| @@ -84,6 +84,7 @@ export class SettingsState { | |||
| hasConfigurationCapability = false; | |||
| useVSCodeContentRequest = false; | |||
| yamlVersion: YamlVersion = '1.2'; | |||
| hasWsChangeWathedFileDynamicRegistraton = false; | |||
There was a problem hiding this comment.
It is better to rename to hasWsChangeWatchedFileDynamicRegistration
evidolob
approved these changes
Nov 26, 2021
msivasubramaniaan
deleted the
fix-lsp-triggering-registerCapability-despite-dynamicRegistration-set-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aceFolder even if dynamicRegistration set to false
What does this PR do?
It checked the client workspace dynamicRegistration true/false on didChangeWatchedFiles. If false, then disable the client/registerCapability call from server to client
What issues does this PR fix or reference?
#583
Is it tested? How?
Yes, tested with tests and with latest changes on neovim.