added oneOf schema validation #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: msivasubramaniaan <[email protected]>
| if (subValidationResult.propertiesMatches === 0) { | ||
| noPropertyMatches.push(subSchema); | ||
| } | ||
| if (subSchema.format) { |
There was a problem hiding this comment.
For address #586 omit the matches when string format matched
|
@gorkem it would be great it this could be reviewed as I'm also experiencing this issue. Surprised it is flagged as an enhancement as it did work at 1.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: msivasubramaniaan [email protected]
What does this PR do?
This PR throws validation error if multiple schema matches from oneOf
What issues does this PR fix or reference?
redhat-developer/vscode-yaml#769
Is it tested? How?
Yes added UT