feat(hwdb): install hwdb on demand when module is needed #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream PR: dracutdevs/dracut#2443 |
|
I don't think this fixes the bug, as explained in https://github.com/dracutdevs/dracut/pull/2443/files#r1271851632. |
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs/dracut#1681 (Cherry-picked commit: 062e739d89543a38d4b3e2cab155912bc4bf9e56) Resolves: #1968118
pvalena
force-pushed
the
rhel-8-fix-1968118
branch
from
378570d
to
5cd3729
Compare
Fixed, tested: https://gist.github.com/pvalena/873bed9e9eb749f127ca7f60c330dd3d |
pvalena
commented
Jul 25, 2023
pvalena
commented
Jul 25, 2023
| @@ -1302,6 +1302,12 @@ if ! [[ -d "$udevdir" ]]; then | |||
| [[ -e /usr/lib/udev/collect ]] && udevdir=/usr/lib/udev | |||
| fi | |||
|
|
|||
| [[ -d $udevconfdir ]] \ | |||
| || udevconfdir="$(pkg-config udev --variable=udevconfdir 2>/dev/null)" | |||
There was a problem hiding this comment.
Not sure what this does, but at least the fallback seems to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default.
Including the module adds 2MB of compressed data (on Fedora, the file has 12MB).
hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces.
Original PR: dracutdevs/dracut#1681
(Cherry-picked commit: ae2ab8c8a65c4ea4f4ad4e8c8f99d493a8f686eb)
Resolves: #1968118