Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use setpriv instead of gosu #402

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jrwren
Copy link

@jrwren jrwren commented Jun 6, 2024

Closes #390
Closes #401

@jrwren
Copy link
Author

jrwren commented Jun 6, 2024

for #401

@jrwren
Copy link
Author

jrwren commented Jun 6, 2024

This is the minimal PR which didn't run apply.sh. Please comment if you'd prefer that I run it to update the dockerfiles.

Copy link
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few minor suggestions, but overall seems fine to me for this case (where we don't need to maintain gosu or a compatible interface for downstream image user compatibility).

This is the minimal PR which didn't run apply.sh. Please comment if you'd prefer that I run it to update the dockerfiles.

Yes, please also run apply-templates.sh.

Dockerfile.template Outdated Show resolved Hide resolved
docker-entrypoint.sh Outdated Show resolved Hide resolved
generate-stackbrew-library.sh Outdated Show resolved Hide resolved
Dockerfile.template Outdated Show resolved Hide resolved
@jrwren
Copy link
Author

jrwren commented Jun 6, 2024

Thank you for the prompt feedback.

Copy link
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@tianon tianon requested a review from yosifkit June 6, 2024 19:54
@walton-io
Copy link

Bumping this.

I've built this image and scanned it with trivy

aa1c716f4b3d (alpine 3.20.1)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

Looks great! Much better than any other redis image i've scanned with alpine or debian

Copy link
Contributor

@yosifkit yosifkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change and would have approved it sooner but didn't want to speak for the new maintainers. We were in the process of getting this repo transferred under the control of upstream Redis which is why this is now under https://github.com/redis/docker-library-redis.

So, while I approve of this, the new maintainers from Redis are now the decision makers and they are welcome to accept or reject this change.

@r-arias
Copy link

r-arias commented Aug 29, 2024

I'd really appreciate it if this could be merged 🙂

Cheers

@kosztyua
Copy link

kosztyua commented Sep 5, 2024

+1 for this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gosu carries many CVE and appears unused Alpine image vulnerability scan regression
6 participants