Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle connection after connect event was emitted #1095

Merged
merged 2 commits into from
Apr 11, 2020
Merged

Handle connection after connect event was emitted #1095

merged 2 commits into from
Apr 11, 2020

Commits on Apr 5, 2020

  1. Handle connection after connect event was emitted 

    It's possible for connect promise to resolve after the resolved
connection has already been established, which means we miss the connect
event. This can happen when Bluebird is set as the global Promise, and
we connect to an ip address host for example. This fix checks to see if
that's the case and invokes the connection handler directly. Thanks
@luin for the recommendation.

Fixes redis#977
    @alavers
    alavers committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    ec76383 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Skip connection timeout when already established

    @alavers
    alavers committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    087d0ee View commit details
    Browse the repository at this point in the history