Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: add tlsSni option - closes #1114 #1115

Closed
wants to merge 2 commits into from

Conversation

alexandre-abrioux
Copy link
Contributor

Hi everyone,

This PR introduces a new boolean option tlsSni that will basically, when enabled, copy the Redis hostname to tls.servername before the connection initialization,
allowing each node of a Redis Cluster to possess its own SNI.

This PR has been opened following the issue #1114

It is also related to #948

Thank you for your time!

@alexandre-abrioux alexandre-abrioux changed the title tls: add tlsSni option - closes #1114 [WIP] tls: add tlsSni option - closes #1114 Apr 28, 2020
@alexandre-abrioux alexandre-abrioux changed the title [WIP] tls: add tlsSni option - closes #1114 tls: add tlsSni option - closes #1114 Apr 29, 2020
@alexandre-abrioux
Copy link
Contributor Author

alexandre-abrioux commented Apr 29, 2020

Added a test for cluster connections.

For clusers I had to copy the options.host value to options.hostOriginal before it gets processed by the dnsLookup function, so that the original hostname could get passed to the tls.servername option instead of its IP.

It should be ready to be reviewed now.
Thank you!

@alexandre-abrioux
Copy link
Contributor Author

changed fork branch, PR moved here:
#1137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant