Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not running callback in pipeline custom command #117

Merged
merged 1 commit into from
Jul 30, 2015
Merged

Fix not running callback in pipeline custom command #117

merged 1 commit into from
Jul 30, 2015

Commits on Jul 29, 2015

  1. Fix not running callback in pipeline custom command 

    The issue is that Pipeline.prototype.sendCommand(...) returns
this (a Pipeline instance for chaining) instead of the command's
Promise (which every other sendCommand method seems to return). When
this Pipeline instance filters down to line 24 in lib/script.js
Script.prototype.execute(...), the condition (result instanceof
Promise) fails and any callback the user might have passed in never
gets attached to the Promise, and is subsequently never run.
    @phlip9
    phlip9 committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    7367fca View commit details
    Browse the repository at this point in the history