feat(cluster): add the option for a custom node selector in scaleReads #252
Conversation
|
Awesome! Thank you for the pull request! It seems better to change |
| return _this.connectionPool.nodes.all[key]; | ||
| }); | ||
| redis = to(nodes, command); | ||
| if (redis.constructor === Array) { |
There was a problem hiding this comment.
if (Array.isArray(redis)) may be better IMO, and we should check whether redis is null/undefined and default to the master node.
There was a problem hiding this comment.
Yes, you are correct. I'm sadly used too much to client-side JS, and Array.isArray is unavailable in some MSIE versions...
There was a problem hiding this comment.
As a hint: there's a easy polyfill for this and Microsoft itself does not maintain IE 8 or older, not even with security fixes on any regular Windows version. Most libraries drop support for it or have already dropped the support and the faster all developers switch to not supporting it anymore, the faster no one is going to visit any website with it anymore.
|
LGTM. Any thoughts about changing |
|
It bothered me too... I'll do that, and make sure the README states it clearly. |
feat(cluster): add the option for a custom node selector in scaleReads
|
Cool! Merged. 👍 |
|
Thanks! |
#250