fix(CLUSTER): fix cluster not disconnected when called disconnect method #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,7 +57,7 @@ function Cluster(startupNodes, options) { | |||
|
|
|||
| var _this = this; | |||
| this.connectionPool.on('-node', function (redis) { | |||
| if (_this.subscriber === redis) { | |||
| if (_this.status === 'ready' && _this.subscriber === redis) { | |||
There was a problem hiding this comment.
We should export possible statuses to an enum to avoid having typos.
something like:
_this.status = Redis.READY
There was a problem hiding this comment.
Enum may not be able to avoid typos IMO. For example, I may wrongly write Redis.READY as Redis.REEDY, and the latter will be an undefined, no exception would be thrown.
There was a problem hiding this comment.
Yeah, but your IDE will probably detect it.
There was a problem hiding this comment.
Not critical though, just saying :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when disconnecting from a cluster, the nodes will be disconnected one by one. However, when the subscriber is disconnected, a new subscriber will be connected to in
-nodeevent, leading the cluster keeping connected.Related issue: #277