perf(cluster): make disconnecting from cluster faster #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will prevent status changes from 'disconnecting' to 'connecting' and will stop connecting to a nodes when disconnecting, which will make disconnecting faster.
luin
force-pushed
the
fix/cluster-better-disconnecting
branch
from
7d7fe22
to
fa124d2
Compare
AVVS
reviewed
Oct 14, 2018
| return wrapper(new Error('Cluster is disconnected.')) | ||
| switch (_this.status) { | ||
| case 'close': | ||
| case 'end': |
There was a problem hiding this comment.
Same error returned for 3 statuses, was this intentional?
There was a problem hiding this comment.
"disconnecting" returns a different error.
There was a problem hiding this comment.
ah, didn't notice the difference at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will prevent status changes from 'disconnecting'
to 'connecting' and will stop connecting to a nodes
when disconnecting, which will make disconnecting faster.