Meaningful variable name for JedisBroadcastException

redis · Aug 30, 2023 · 929d92d · 929d92d
1 parent 7af02d5
commit 929d92d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/main/java/redis/clients/jedis/exceptions/JedisBroadcastException.java b/src/main/java/redis/clients/jedis/exceptions/JedisBroadcastException.java
@@ -8,6 +8,7 @@
  * Note: This exception extends {@link JedisDataException} just so existing applications catching
  * JedisDataException do not get broken.
  */
+// TODO: extends JedisException
 public class JedisBroadcastException extends JedisDataException {
 
   private static final String BROADCAST_ERROR_MESSAGE = "A failure occurred while broadcasting the command.";

diff --git a/src/main/java/redis/clients/jedis/executors/ClusterCommandExecutor.java b/src/main/java/redis/clients/jedis/executors/ClusterCommandExecutor.java
@@ -43,14 +43,14 @@ public final <T> T broadcastCommand(CommandObject<T> commandObject) {
 
     boolean isErrored = false;
     T reply = null;
-    JedisBroadcastException holder = new JedisBroadcastException();
+    JedisBroadcastException bcastError = new JedisBroadcastException();
     for (Map.Entry<String, ConnectionPool> entry : connectionMap.entrySet()) {
       HostAndPort node = HostAndPort.from(entry.getKey());
       ConnectionPool pool = entry.getValue();
       try (Connection connection = pool.getResource()) {
         try {
           T aReply = execute(connection, commandObject);
-          holder.addReply(node, aReply);
+          bcastError.addReply(node, aReply);
           if (isErrored) { // already errored
           } else if (reply == null) {
             reply = aReply; // ok
@@ -61,12 +61,12 @@ public final <T> T broadcastCommand(CommandObject<T> commandObject) {
             reply = null;
           }
         } catch (JedisDataException anError) {
-          holder.addError(node, anError);
+          bcastError.addError(node, anError);
         }
       }
     }
     if (isErrored) {
-      throw holder;
+      throw bcastError;
     }
     return reply;
   }