Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubsub handle array of messages #3512

Conversation

sankarcheppali
Copy link

For client tracking, redis sends array instead of a single message (handled this by checking the instance of the bmesg before casting it to byte array)

https://redis.io/docs/manual/client-side-caching/

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2023

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 82.10%. Comparing base (2d42338) to head (ffe709f).

Files Patch % Lines
...main/java/redis/clients/jedis/JedisPubSubBase.java 66.66% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3512      +/-   ##
============================================
- Coverage     82.13%   82.10%   -0.03%     
- Complexity     6016     6017       +1     
============================================
  Files           301      301              
  Lines         15273    15282       +9     
  Branches       1190     1193       +3     
============================================
+ Hits          12544    12547       +3     
- Misses         2162     2163       +1     
- Partials        567      572       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16
Copy link
Collaborator

@sankarcheppali Why do you want this change? Are you implementing client side caching for yourself?

@sankarcheppali
Copy link
Author

Hello @sazzad16 , yes this is for client side caching.

@sazzad16
Copy link
Collaborator

yes this is for client side caching.

@sankarcheppali Where?

Would you implement client side caching only for your application or for Jedis?

@sankarcheppali
Copy link
Author

yes this is for client side caching.

@sankarcheppali Where?

Would you implement client side caching only for your application or for Jedis?

Hi, I am trying to implement in my application, and when I register for the invalidation channel, the code is failing due to type casting issue.

@sankarcheppali
Copy link
Author

Hi @sazzad16 , I would also like to backport this to 3.x, Please let me know if this is acceptable.

@chayim
Copy link
Contributor

chayim commented Sep 21, 2023

Please feel free to submit a pull request! But, client side caching is planned for an upcoming release of Jedis. Of course, you'll need to use a more recent version, as that occurs.

@sankarcheppali
Copy link
Author

Please feel free to submit a pull request! But, client side caching is planned for an upcoming release of Jedis. Of course, you'll need to use a more recent version, as that occurs.

@chayim could you please check this #3564

@sazzad16
Copy link
Collaborator

sazzad16 commented Apr 9, 2024

Resolved by #3811

@sazzad16 sazzad16 closed this Apr 9, 2024
@sazzad16
Copy link
Collaborator

sazzad16 commented Apr 9, 2024

Thank you @sankarcheppali for this PR. This helped me writing the tests in #3811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants