Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on Redis compiled from source code #3734

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Feb 21, 2024

  1. Do not rely on Redis compiled from source code

    Issue redis#3710
    
    Instead of building Redis server from source code, use Docker images.
    Prepare docker-compose stacks that accept the version of the Docker
    image as parameter, so we can run against multiple versions in CI.
    
    The purpose of this change is to strictly move everything to Docker,
    without trying to change anything else. Some Java tests had to be
    adapted, still, because now the Redis instances are accessed via
    localhost, while internally in the docker-compose network they see each
    other with other IPs and ports.
    
    Polish a bit the Makefile, for example to run exactly the same thing
    that runs in CI, so when we run the tests locally we get exactly the
    same coverage.
    gerzse committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9286d0c View commit details
    Browse the repository at this point in the history
  2. Undo some changes

    Don't change some imports so much.
    
    Fix a typo, that was me trying to open pavucontrol.
    gerzse committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    1f49d5e View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Fix failing tests and react to code review

    Fix some failing tests, the mapping of hosts/ports was broken by the
    earlier changes.
    
    Move some core around, as suggested during code review.
    gerzse committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    e804b9d View commit details
    Browse the repository at this point in the history