-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensive tests for UnifiedJedis #3788
Merged
Merged
Commits on Mar 25, 2024
-
Align Pipelined commands with UnifiedJedis
Add some Pipelined commands that are available in UnifiedJedis but are missing the pipelined version.
Configuration menu - View commit details
-
Copy full SHA for 6c8d14d - Browse repository at this point
Copy the full SHA 6c8d14dView commit details -
Add extensive tests for UnifiedJedis
Add mocked tests for UnifiedJedis. Most of the code is covered, except the constructors and some iterator methods. Those are left for later. Take the opportunity to split PipeliningTests into smaller test classes. The idea is to have one superclass (MockCommandObjectsTest) that exposes a variety of mocked CommandObjects. From there we branch in two directions: towards PipeliningBase and towards UnifiedJedis. Each has a test superclass that prepares mocked instances, and a set of concrete test classes that contain the actual tests. The tests are grouped in categories. The names of the categories are the same as used on the redis.io website in the commands documentation page. Inside each section (i.e. test class), the tested commands are ordered alphabetically. The tests run in pairs, one for the string-based command, and one for the equivalent byte-array-based command. Hopefully this gives a good structure for following the code. A new public constructor is needed in UnifiedJedis, in order to inject the mocks. Also, due to method visibility, one test class for UnifiedJedis must reside in the same package as the class itself.
Configuration menu - View commit details
-
Copy full SHA for 6e3d40c - Browse repository at this point
Copy the full SHA 6e3d40cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c4a679 - Browse repository at this point
Copy the full SHA 7c4a679View commit details -
Configuration menu - View commit details
-
Copy full SHA for c142c1c - Browse repository at this point
Copy the full SHA c142c1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3365ec3 - Browse repository at this point
Copy the full SHA 3365ec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72dd39b - Browse repository at this point
Copy the full SHA 72dd39bView commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dd0088f - Browse repository at this point
Copy the full SHA dd0088fView commit details -
Configuration menu - View commit details
-
Copy full SHA for acf0cb2 - Browse repository at this point
Copy the full SHA acf0cb2View commit details
Commits on Apr 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5171f7a - Browse repository at this point
Copy the full SHA 5171f7aView commit details -
Rename classes as suggested. Move some tests into better suited classed. Remove everything Graph related.
Configuration menu - View commit details
-
Copy full SHA for db387ef - Browse repository at this point
Copy the full SHA db387efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03f2745 - Browse repository at this point
Copy the full SHA 03f2745View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.