Export utils and commands to share (with sentinel client, or others) #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 30, 2013 11:58
(originally 274f846 by Tanguy Le Barzic <tanguy@Zorro2.(none)>, without sentinel.js)
ghost
assigned 
| return Array.isArray(obj) && obj.length === 0; | ||
| } | ||
| // separated test helpers | ||
| var testUtils = require('./utils'), |
There was a problem hiding this comment.
This causes an error, needs to be:
var testUtils = require('./test_utils'),
|
Other than the comment above that is required to make the tests run, looks good. |
|
@benbuckman You going to make the minor update so it can be merged in? |
|
Ping @benbuckman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports redis-sentinel-client. It should not change or break any node_redis functionality, it simply separates and/or exports pieces that can be used by other modules. (Which should be good architecture regardless of the sentinel client or other modules using it.)
Thanks!