Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SVG icons in Redmine6 #61

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

takenory
Copy link
Collaborator

@takenory takenory commented Nov 11, 2024

This pull request includes several updates to the user interface and compatibility improvements for the Redmine Issues Panel plugin. The most important changes include the addition of sprite icons to various UI elements and the update of the required Redmine version.

User Interface Enhancements:

  • Added sprite icons to the "New Issue Category" and "New Version" links in the issue modal form (app/views/issues_panel/_modal_form.html.erb). [1] [2]
  • Enhanced the query form by adding sprite icons to the filter and options legends and the apply, clear, save, and edit buttons (app/views/issues_panel/_query_form.html.erb). [1] [2]
  • Updated the "New Issue" link in the issues panel index to use a sprite icon (app/views/issues_panel/index.html.erb).

Compatibility Improvements:

  • Updated the required Redmine version to 6.0 in the plugin initialization file (init.rb).

Codebase Updates:

  • Modified the render_issue_cards and render_issues_panel methods to include sprite icons for the "New Issue" button (lib/redmine/helpers/issues_panel.rb). [1] [2]

Copy link
Contributor

@hidakatsuya hidakatsuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this pull request look good to me. I reviewed the code and verified the functionality.

@takenory
Copy link
Collaborator Author

takenory commented Nov 15, 2024

Additionally, Replaced toggle icons with SVG when panels are grouped. b829ee2

@takenory takenory merged commit 2e79df6 into redmica:master Nov 15, 2024
2 checks passed
@takenory takenory deleted the support-redmine6 branch November 15, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants