add deps to useSelector to allow controlling stability of selector
#1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrWolfZ
commented
Apr 22, 2019
| }) | ||
|
|
||
| describe('edge cases', () => { | ||
| it('ignores transient errors in selector (e.g. due to stale props)', () => { | ||
| // TODO Not sure this test is really testing what we want. |
There was a problem hiding this comment.
This test was correct in what it tested. In fact, it failing showed an error in the implementation.
|
Deploy preview for react-redux-docs ready! Built with commit 143ca4e |
MrWolfZ
commented
Apr 22, 2019
|
|
||
| let selectedState = undefined | ||
|
|
||
| try { | ||
| selectedState = latestSelector.current(store.getState()) | ||
| selectedState = memoizedSelector(store.getState()) |
There was a problem hiding this comment.
using latestSelector.current was wrong, since it was a stale selector. This change fixes that issue, which makes the test for stale props succeed.
|
If no dependency array is passed what happens? |
|
@Dudeonyx : the latest passed-in selector should get used, instead of a previous one. |
|
LGTM. I'll try to get alpha.1 published shortly. |
timdorr
pushed a commit
that referenced
this pull request
May 30, 2019
#1251) * fix stale selector issue * add `deps` to `useSelector` to allow controlling stability of selector
timdorr
pushed a commit
that referenced
this pull request
Jun 11, 2019
#1251) * fix stale selector issue * add `deps` to `useSelector` to allow controlling stability of selector
This was referenced Sep 3, 2019
This was referenced Oct 26, 2019
This was referenced Apr 9, 2020
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
reduxjs#1251) * fix stale selector issue * add `deps` to `useSelector` to allow controlling stability of selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
depsparameter touseSelectoras discussed here.It also fixes an issue with staleness of the selector.