Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free resources (free detached nodes from memory) #1380

Merged
merged 4 commits into from
Aug 18, 2019
Merged

Free resources (free detached nodes from memory) #1380

merged 4 commits into from
Aug 18, 2019

Commits on Aug 15, 2019

  1. Free resources (free detached nodes from memory) 

    Found an issue when using virtualized list (https://github.com/bvaughn/react-virtualized), where unmounted react components (connected to store using connect) were not collected by the garbage collector. 
I'm not sure what is the exact explanation here, but it solved my problem.
    @MosheZemah
    MosheZemah authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    e6f7bca View commit details
    Browse the repository at this point in the history

  2. Fix lint issue

    @MosheZemah
    MosheZemah authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    8f8e3ce View commit details
    Browse the repository at this point in the history

  3. Fix lint issue

    @MosheZemah
    MosheZemah authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    2fa0618 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. Update src/components/connectAdvanced.js 

    Remove comment

Co-Authored-By: Tim Dorr <[email protected]>
    @MosheZemah @timdorr
    MosheZemah and timdorr authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    8c7001e View commit details
    Browse the repository at this point in the history