Use the same condition for checking if SSR in useSelector.js as in connectAdvanced.js #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit 94bd771 |
|
Thanks! |
This was referenced Apr 9, 2020
webguru7
pushed a commit
to webguru7/react-redux
that referenced
this pull request
Dec 8, 2022
aungkoman
pushed a commit
to ReactJSMyanmar/react-redux
that referenced
this pull request
Dec 28, 2023
…nnectAdvanced.js (reduxjs#1419) LeoDanielsson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In connectAdvanced.js, window.document.createElement is checked to determine whether the code is running server side. In useSelector only window !== undefined is checked.
Many projects polyfill window on the server, which causes the useLayoutEffect warning when using useSelector. Changing to the more specific condition fixes this.