connect doesn't apply ref to stateless component #143
Conversation
| if (isStateless) { | ||
| return <WrappedComponent {...this.nextState} />; | ||
| } | ||
|
|
There was a problem hiding this comment.
This should probably not be here. If we decide to go ahead with this, we should probably create render above and apply it to this class.
bspaulding
force-pushed
the
stateless-wrapped-component-ref
branch
from
3c70fdf
to
f4f2d1f
Compare
|
Wouldn't this give false positives for module pattern of non-Component-inheriting classes which are still valid in 0.14? |
|
Yes, indeed. I'm not sure at this point how you'd figure that out before mounting the component. I'll keep hacking on it. |
| return <span className={this.state.value} />; | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
I assume this is the case you're talking about?
There was a problem hiding this comment.
Hmm, interestingly, this turns out to not be a false positive. At least, React thinks this is stateless, and shows the warning.
There was a problem hiding this comment.
Sorry, I got confused. This spec is bad, wrapping it in a function below.
|
Thanks for the PR. Closed via 2d3d0be. |
Took a stab at #141
Probably would be better to create the render function beforehand, instead of hitting that conditional every render. Just getting this out there for discussion.
Worth noting that the detection isn't perfect, but solves the case mentioned here, and keeps the current test for wrappedInstance ref passing. We'd have to instantiate the component to know for sure, but this might be good enough.
Pretty much stole the check from ReactCompositeComponent