Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop now-unneeded RN peer dep #2167

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

markerikson
Copy link
Contributor

We listed React Native as a peer dep because we needed to import unstable_batchedUpdates.

We no longer depend on that at all since React batches natively, and we don't have a single "react-native" reference in the source.

This is ultimately the reason why NPM is blowing up with peer dep mismatches, so dropping that peer dep listing should hopefully fix things.

Copy link

codesandbox-ci bot commented May 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@markerikson
Copy link
Contributor Author

Confirmed on a fresh local Next app that we get the failure with "react-redux": "^9" and npm i @reduxjs/toolkit", and that npm i works with this PR's build.

@markerikson markerikson merged commit bfa3c36 into master May 2, 2024
25 checks passed
@markerikson markerikson deleted the bugfix/remove-rn-peerdep branch May 2, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant