Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract JSONTree #86

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Extract JSONTree #86

merged 1 commit into from
Aug 26, 2015

Conversation

chibicode
Copy link
Contributor

@chibicode
Copy link
Contributor Author

Note: I realized that JSONTree actually doesn't work if theme prop is missing.

As an emergency fix, I copied over solarized.js and made it as the default theme for JSONTree if its theme prop is missing. This way, users don't have to set the themes themselves for most use cases.

I chose Solarized (even though it's not the default for redux-devtools) because I think most people will use JSONTree standalone on a white background (it's also the default browser background color), and I found that Solarized is most legible for white backgrounds.

I think the longer term solution would be to maybe pull out redux-devtools's themes directory into its own package and require it on both LogMonitor and react-json-tree. What do you think?

Here's the commit for adding a default theme. The screenshot is below (this is also on the README of react-json-tree.)



Finally, I also added an example for JSONTree.

gaearon added a commit that referenced this pull request Aug 26, 2015
@gaearon gaearon merged commit 6c81eeb into reduxjs:master Aug 26, 2015
@gaearon
Copy link
Contributor

gaearon commented Aug 26, 2015

Awesome job.

@chibicode
Copy link
Contributor Author

@gaearon thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants