Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code of conduct and contributing files #395

Merged
merged 6 commits into from
Feb 26, 2020
Merged

Add code of conduct and contributing files #395

merged 6 commits into from
Feb 26, 2020

Conversation

julioxavierr
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Feb 26, 2020 •
edited
Loading

Deploy preview for redux-starter-kit-docs ready!

Built with commit 7f76e58

https://deploy-preview-395--redux-starter-kit-docs.netlify.com

markerikson
markerikson reviewed Feb 26, 2020
View reviewed changes
CONTRIBUTING.md
git clone https://github.com/your-username/redux-toolkit.git
```

### Building
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section needs to be updated to match the actual build scripts we have. We don't have separate commands for different module types - we have one build command that generates everything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. It still create CommonJS and UMD?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you can see we pass those args to TSDX.

@markerikson markerikson mentioned this pull request Feb 26, 2020
Closed
@markerikson
Copy link
Collaborator

Also, the Travis build is failing because both files need to be formatted with Prettier.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 26, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7f76e58:

Sandbox Source
mystifying-bash-ls8px Configuration
happy-newton-pjhpt Configuration
busy-chatterjee-737bj Configuration

phryneas
phryneas reviewed Feb 26, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@markerikson
Copy link
Collaborator

Looks like that should work. Thanks!

@markerikson markerikson merged commit 92b32db into reduxjs:master Feb 26, 2020
@julioxavierr julioxavierr deleted the feat/contributing branch February 26, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phryneas phryneas phryneas left review comments

@markerikson markerikson markerikson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julioxavierr @markerikson @phryneas