Use same return type for both StoreCreator signatures in TS typings #2985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a refactor, I noticed that removing the
preloadedState
param from acreateStore
call resulted in a different type than callingcreateStore
withpreloadedState
. This is due to the return type ofStoreCreator
being slightly different for each signature. Specifically, the one withoutpreloadedState
does not include a type param for the action type.This PR adds the action as a type param for the return type of the
createStore
function without apreloadedState
param, as well as a couple of additional tests intests/typescript/store.ts
that make sure the action type param is included in the return type for both signatures.