fix: Throw error if createStore is passed several enhancers #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added two checks - one if you're passing something like createStore(reducer, func, anotherFunc) // throws, and another one if you pass initial state as well: createStore(reducer, { initial: 'state' }, func, anotherFunc) // throwsI'm up for changing whatever - but I'd love some feedback first! |
selbekk
force-pushed
the
3114-add-sanity-check-for-enhancers
branch
from
3ea269a
to
61669bc
Compare
This commit adds a check for whether the user is passing several enhancers to the `createStore` function. Fixes reduxjs#3114.
selbekk
force-pushed
the
3114-add-sanity-check-for-enhancers
branch
from
61669bc
to
32acbea
Compare
|
Looks good to me. @timdorr , any objections? |
|
LGTM. Thanks! |
This was referenced Sep 23, 2019
This was referenced Mar 11, 2020
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check for whether the user is passing several
enhancers to the
createStorefunction.Fixes #3114.