fix replaceReducer type #3507
Merged
fix replaceReducer type #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-docs ready! Built with commit 6b76c98 |
|
Deploy preview for redux-docs ready! Built with commit 500265f |
|
We should probably add some tests against those new types. |
|
|
@timdorr pushed a test, let me know if you think more is needed |
|
That's a good enough start for me. Thanks! |
|
Oh crap, I missed that this was supposed to be against master. Welp, we can wait until the full TS conversion is done. |
|
No worries, I only did it against master because that was one of 2 options, and this one is just fine too |
6 tasks
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
* fix replaceReducer type * remove extraneous type * Update the JSDoc so IDEs don't complain. * new test for replaceReducers Co-authored-by: Tim Dorr <[email protected]> Former-commit-id: 65ca503 Former-commit-id: e90d501
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
* fix replaceReducer type * remove extraneous type * Update the JSDoc so IDEs don't complain. * new test for replaceReducers Co-authored-by: Tim Dorr <[email protected]> Former-commit-id: 65ca503 Former-commit-id: e90d501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
replaceReducerfunction assumes that the reducer state stays in the same shape. This does not make sense, as the purpose ofreplaceReduceris to change the store state.However, typescript types are static, and replaceReducer changes the type at run-time.
To solve this issue, we either need to cast the existing store to the new store type, or transform the store.
As it turns out, a simple solution is to modify the signature for
replaceReducerto return the existing store, and this gives us the ability to typecast to the new reducer type in a graceful way.With this change, the
combineReducerstest passes when converted to typescript with minimal changes.This may also fix #3482