Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: Resolve TS extensions with node-resolve plugin #3517

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

nickserv
Copy link
Contributor

No description provided.

@nickserv
Copy link
Contributor Author

@cellog Please take a look, this allows files other than index.ts to use the .ts extension, without using the TypeScript plugin.

@cellog
Copy link
Contributor

cellog commented Aug 17, 2019

this is great! I'll close mine

@cellog
Copy link
Contributor

cellog commented Aug 18, 2019

unfortunately, this does not work. the CommonJS and ES builds do not use nodeResolve, so I am going to re-open the other PR that uses the typescript plugin

@nickserv
Copy link
Contributor Author

I added it to all confirmations, so it should work. What’s the use case that’s failing?

@cellog
Copy link
Contributor

cellog commented Aug 18, 2019

I added it to all confirmations, so it should work. What’s the use case that’s failing?

The use case where I hand-copied to my own PR without adding it to the first 2 🤣

I'll sit down over there...

@nickserv
Copy link
Contributor Author

Ah ok, so this is ready to merge?

@cellog
Copy link
Contributor

cellog commented Aug 18, 2019

from my seat, this works as advertised, yes

@nickserv
Copy link
Contributor Author

@timdorr Would you mind merging? Thanks!

@nickserv nickserv changed the title Resolve TS extensions with node-resolve plugin TypeScript: Resolve TS extensions with node-resolve plugin Aug 18, 2019
@timdorr timdorr merged commit 2e15b68 into reduxjs:ts-conversion Aug 19, 2019
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants