TypeScript: Fix linter configuration for test files #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickserv
commented
Aug 18, 2019
| @@ -34,9 +34,11 @@ module.exports = { | |||
|
|
|||
| overrides: [ | |||
| { | |||
| files: 'test/**/*.js', | |||
| env: { | |||
| jest: true | |||
There was a problem hiding this comment.
I removed this because it's no longer necessary, as all the test files are now in TypeScript, and TypeScript will make sure the Jest globals are used properly
nickserv
commented
Aug 18, 2019
nickserv
commented
Aug 18, 2019
nickserv
changed the title
nickserv
commented
Aug 19, 2019
| '@typescript-eslint/no-namespace': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off' | ||
| } | ||
| } |
There was a problem hiding this comment.
These rules aren't useful for the TypeScript tests because the code doesn't actually run, it's just meant to be typechecked
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.